ft(listAdds): implement ads list #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #32 +/- ##
==========================================
+ Coverage 74.39% 74.72% +0.32%
==========================================
Files 87 88 +1
Lines 2121 2160 +39
Branches 324 331 +7
==========================================
+ Hits 1578 1614 +36
- Misses 518 521 +3
Partials 25 25 ☔ View full report in Codecov by Sentry. |
yvanddniyo
force-pushed
the
ft-list-add-#187984465
branch
from
cd77e78 to
23d878f
Compare
yvanddniyo
requested review from
soleil00,
MugemaneBertin2001,
niyobertin,
teerenzo,
Jovz19200 and
Heisjabo
yvanddniyo
force-pushed
the
ft-list-add-#187984465
branch
from
23d878f to
eaaae0d
Compare
niyobertin
approved these changes
Jul 28, 2024
yvanddniyo
force-pushed
the
ft-list-add-#187984465
branch
from
eaaae0d to
86eef19
Compare
yvanddniyo
force-pushed
the
ft-list-add-#187984465
branch
from
86eef19 to
d44bcc9
Compare
yvanddniyo
force-pushed
the
ft-list-add-#187984465
branch
from
d44bcc9 to
cb00c64
Compare
Heisjabo
approved these changes
Jul 30, 2024
- listing ads on the homepage [Delivered #187984465]
yvanddniyo
force-pushed
the
ft-list-add-#187984465
branch
from
cb00c64 to
82e8872
Compare
|
Code Climate has analyzed commit 82e8872 and detected 0 issues on this pull request. View more on Code Climate. |
teerenzo
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR do?
This PR list ads on the home page
Description of the task
Every client will be allowed to view the products ads on landing page.
How should this manually tested ?
Clone the repository.
Checkout to the branch ft-list-add-#187984465.
Run npm install to install dependencies.
Run npm run dev to start the development server
Navigate to the page of the homepage and scroll down little a bit
Congratulation you are watching live ads.
What are the relevant pivotal tracker stories?
[Delivered #187984465]